Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.diff-so-fancy: Fix shebang patching and clean up #95909

Merged
merged 1 commit into from Aug 21, 2020
Merged

gitAndTools.diff-so-fancy: Fix shebang patching and clean up #95909

merged 1 commit into from Aug 21, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 21, 2020

Motivation for this change

perl is a runtime dependency so it needs to be in buildInputs, otherwise patchShebangs hook will not see it. This impurity was revealed by #91213

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
gitAndTools.diff-so-fancy: Fix shebang patching and clean up
eae733c 
perl is a runtime dependency so it needs to be in buildInputs,
otherwise patchShebangs hook will not see it.
jonringer
jonringer approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95909 1

1 package built:
- gitAndTools.diff-so-fancy

@jonringer jonringer merged commit 2b6f959 into NixOS:master Aug 21, 2020
@jtojnar jtojnar deleted the g-s-f-sheba-fix branch September 2, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @jonringer