Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knightos-kcc: init at 4.0.0 #95891

Merged
merged 1 commit into from Aug 28, 2020
Merged

knightos-kcc: init at 4.0.0 #95891

merged 1 commit into from Aug 28, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Aug 21, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have added some suggested improvements.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/kcc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/kcc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/kcc/default.nix Show resolved Hide resolved
@siraben siraben force-pushed the kcc-init branch 2 times, most recently from 1c58ae1 to 72afb76 Compare August 22, 2020 02:25
@siraben siraben changed the title knightos_c: init at 4.0.0 knightos-kcc: init at 4.0.0 Aug 22, 2020
@siraben siraben mentioned this pull request Aug 22, 2020
Closed
@siraben siraben requested a review from danieldk August 23, 2020 05:31
@siraben
Copy link
Member Author

siraben commented Aug 27, 2020

I think it's ready to merge.

danieldk
danieldk suggested changes Aug 27, 2020
View reviewed changes
pkgs/development/compilers/kcc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/kcc/default.nix Outdated Show resolved Hide resolved
@siraben siraben requested a review from danieldk August 28, 2020 11:54
danieldk
danieldk approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95891 1

1 package built:
- knightos-kcc

@danieldk danieldk merged commit 4eb9188 into NixOS:master Aug 28, 2020
@siraben siraben deleted the kcc-init branch August 28, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @danieldk