Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Z3 4.8.8 #95912

Merged
merged 2 commits into from Aug 22, 2020
Merged

Z3 4.8.8 #95912

merged 2 commits into from Aug 22, 2020

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Aug 21, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor

zowoq commented Aug 21, 2020

@ofborg eval

@ofborg ofborg bot requested a review from thoughtpolice August 21, 2020 23:54
jonringer
jonringer approved these changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/95912
7 packages failed to build:
cryptol petrinizer python37Packages.cozy python37Packages.slither-analyzer python38Packages.cozy slither-analyzer solc

15 packages built:
acl2 boogie cppcheck dafny fstar isabelle python27Packages.z3 python37Packages.z3 python38Packages.z3 rsstail tlaps vampire z3 z3-tptp zz

@jonringer jonringer merged commit 616dd21 into NixOS:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ttuegel @zowoq @jonringer