Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: use system-sendmail #95898

Merged
merged 1 commit into from Aug 21, 2020
Merged

php: use system-sendmail #95898

merged 1 commit into from Aug 21, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Aug 21, 2020 •
edited

By default PHP is looking for sendmail in /usr/bin/sendmail which isn't a correct path for NixOS.

Motivation for this change

Fixes #95856.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
php: use system-sendmail
1d43f34 
By default PHP is looking for sendmail in /usr/bin/sendmail
which isn't a correct path for NixOS.
@KamilaBorowska
Copy link
Member Author

9 packages failed to build:
hhvm php73Extensions.v8 php73Extensions.v8js php73Extensions.zmq php74Extensions.pcs php74Extensions.pthreads php74Extensions.v8 php74Extensions.v8js php74Extensions.zmq

202 packages built:
adminer arcanist drush engelsystem icingaweb2 kcachegrind lsp-plugins piwik matomo-beta nagios nextcloud-news-updater phoronix-test-suite php php73 php73Extensions.apcu php73Extensions.apcu_bc php73Extensions.ast php73Extensions.bcmath php73Extensions.bz2 php73Extensions.calendar php73Extensions.couchbase php73Extensions.ctype php73Extensions.curl php73Extensions.dba php73Extensions.dom php73Extensions.enchant php73Extensions.event php73Extensions.exif php73Extensions.fileinfo php73Extensions.filter php73Extensions.ftp php73Extensions.gd php73Extensions.gettext php73Extensions.gmp php73Extensions.hash php73Extensions.iconv php73Extensions.igbinary php73Extensions.imagick php73Extensions.imap php73Extensions.intl php73Extensions.json php73Extensions.ldap php73Extensions.mailparse php73Extensions.maxminddb php73Extensions.mbstring php73Extensions.memcached php73Extensions.mongodb php73Extensions.mysqli php73Extensions.mysqlnd php73Extensions.oci8 php73Extensions.opcache php73Extensions.openssl php73Extensions.pcntl php73Extensions.pcov php73Extensions.pcs php73Extensions.pdo php73Extensions.pdo_dblib php73Extensions.pdo_mysql php73Extensions.pdo_oci php73Extensions.pdo_odbc php73Extensions.pdo_pgsql php73Extensions.pdo_sqlite php73Extensions.pdo_sqlsrv php73Extensions.pgsql php73Extensions.php_excel php73Extensions.pinba php73Extensions.posix php73Extensions.protobuf php73Extensions.pspell php73Extensions.pthreads php73Extensions.rdkafka php73Extensions.readline php73Extensions.redis php73Extensions.session php73Extensions.shmop php73Extensions.simplexml php73Extensions.snmp php73Extensions.soap php73Extensions.sockets php73Extensions.sodium php73Extensions.sqlite3 php73Extensions.sqlsrv php73Extensions.sysvmsg php73Extensions.sysvsem php73Extensions.sysvshm php73Extensions.tidy php73Extensions.tokenizer php73Extensions.wddx php73Extensions.xdebug php73Extensions.xml php73Extensions.xmlreader php73Extensions.xmlrpc php73Extensions.xmlwriter php73Extensions.xsl php73Extensions.yaml php73Extensions.zend_test php73Extensions.zip php73Extensions.zlib php73Packages.box php73Packages.composer php73Packages.php-cs-fixer php73Packages.php-parallel-lint php73Packages.phpcbf php73Packages.phpcs php73Packages.phpmd php73Packages.phpstan php73Packages.psalm php74Extensions.apcu php74Extensions.apcu_bc php74Extensions.ast php74Extensions.bcmath php74Extensions.bz2 php74Extensions.calendar php74Extensions.couchbase php74Extensions.ctype php74Extensions.curl php74Extensions.dba php74Extensions.dom php74Extensions.enchant php74Extensions.event php74Extensions.exif php74Extensions.ffi php74Extensions.fileinfo php74Extensions.filter php74Extensions.ftp php74Extensions.gd php74Extensions.gettext php74Extensions.gmp php74Extensions.iconv php74Extensions.igbinary php74Extensions.imagick php74Extensions.imap php74Extensions.intl php74Extensions.json php74Extensions.ldap php74Extensions.mailparse php74Extensions.maxminddb php74Extensions.mbstring php74Extensions.memcached php74Extensions.mongodb php74Extensions.mysqli php74Extensions.mysqlnd php74Extensions.oci8 php74Extensions.opcache php74Extensions.openssl php74Extensions.pcntl php74Extensions.pcov php74Extensions.pdo php74Extensions.pdo_dblib php74Extensions.pdo_mysql php74Extensions.pdo_oci php74Extensions.pdo_odbc php74Extensions.pdo_pgsql php74Extensions.pdo_sqlite php74Extensions.pdo_sqlsrv php74Extensions.pgsql php74Extensions.php_excel php74Extensions.pinba php74Extensions.posix php74Extensions.protobuf php74Extensions.pspell php74Extensions.rdkafka php74Extensions.readline php74Extensions.redis php74Extensions.session php74Extensions.shmop php74Extensions.simplexml php74Extensions.snmp php74Extensions.soap php74Extensions.sockets php74Extensions.sodium php74Extensions.sqlite3 php74Extensions.sqlsrv php74Extensions.sysvmsg php74Extensions.sysvsem php74Extensions.sysvshm php74Extensions.tidy php74Extensions.tokenizer php74Extensions.xdebug php74Extensions.xml php74Extensions.xmlreader php74Extensions.xmlrpc php74Extensions.xmlwriter php74Extensions.xsl php74Extensions.yaml php74Extensions.zend_test php74Extensions.zip php74Extensions.zlib php74Packages.box php74Packages.composer php74Packages.php-cs-fixer php74Packages.php-parallel-lint php74Packages.phpcbf php74Packages.phpcs php74Packages.phpmd php74Packages.phpstan php74Packages.psalm pulseeffects qcachegrind unit wp-cli yle-dl

@aanderse aanderse requested review from Ma27 and talyz August 21, 2020 14:57
aanderse
aanderse approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Looking for one more approval before merge. Thanks @xfix 🎉

@aanderse
Copy link
Member

@GrahamcOfBorg build php

@ofborg ofborg bot requested review from aanderse, globin and etu August 21, 2020 18:24
@Ma27 Ma27 merged commit 18f6323 into NixOS:master Aug 21, 2020
@KamilaBorowska KamilaBorowska mentioned this pull request Oct 1, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@talyz talyz Awaiting requested review from talyz talyz is a code owner

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

@globin globin Awaiting requested review from globin globin is a code owner

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

php: sh: /usr/sbin/sendmail: No such file or directory
3 participants
@KamilaBorowska @aanderse @Ma27