Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/network-interfaces: fix too restrictive assertion on DHCP for bridges #95917

Closed

Conversation

erikarvstedt
Copy link
Member

@erikarvstedt erikarvstedt commented Aug 21, 2020

Deleted. This PR was based on wrong assumptions.

…ridges

The old assertion rejected sensible NixOS configs like this:
```
{
  networking.useDHCP = true; # this is the NixOS default
  networking.bridges.mybr.interfaces = [];
  networking.interfaces.mybr.useDHCP = false;
}
```
This config reflects the common use case of enabling DHCP for physical
NICs while adding a statically configured bridge.

Configs of this kind are now allowed.

All configs rejected by the new assertion were also
rejected by the old assertion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant