coolreader: init at 3.2.45 #95923
Merged
coolreader: init at 3.2.45 #95923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg eval |
jonringer
reviewed
Aug 21, 2020
Comment on lines
7
to
13
| src = fetchFromGitHub { | ||
| owner = "adah1972"; | ||
| repo = pname; | ||
| rev = "libunibreak_4_3"; | ||
| sha256 = "19g3ixs1ycisfdnzd8v7j5r49h0x0hshchk9qwlz4i0mjv825plx"; |
There was a problem hiding this comment.
to better support updates
Suggested change
| src = fetchFromGitHub { | |
| owner = "adah1972"; | |
| repo = pname; | |
| rev = "libunibreak_4_3"; | |
| sha256 = "19g3ixs1ycisfdnzd8v7j5r49h0x0hshchk9qwlz4i0mjv825plx"; | |
| src = let | |
| rev_version = stdenv.lib.replaceStrings ["-"] ["_"] version; | |
| in fetchFromGitHub { | |
| owner = "adah1972"; | |
| repo = pname; | |
| rev = "libunibreak_${rev_version}"; | |
| sha256 = "19g3ixs1ycisfdnzd8v7j5r49h0x0hshchk9qwlz4i0mjv825plx"; |
There was a problem hiding this comment.
needs to be
stdenv.lib.replaceStrings ["."] ["_"] not -. Getting 404 from at the moment github...
There was a problem hiding this comment.
Oops, apparently ofborg didn't catch this because it had already cached the download... Fixed in 2446a98
jtojnar
reviewed
Aug 21, 2020
| sha256 = "0nkk4d0j04yjwanjszq8h8hvx87rnwax2k6akm4bpjxwpcs4icws"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ cmake pkgconfig ]; |
There was a problem hiding this comment.
In new expressions, pkg-config should be used instead of the pkgconfig alias.
| meta = with lib; { | ||
| homepage = "https://github.com/buggins/coolreader"; | ||
| description = "Cross platform open source e-book reader"; | ||
| license = licenses.gpl2Only; # see https://github.com/buggins/coolreader/issues/80 |
There was a problem hiding this comment.
This comment says -or-later: buggins/coolreader#80 (comment)
|
@GrahamcOfBorg build fbreader |
|
@ofborg eval |
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New package. Coolreader is an e-book reader.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)