zfs: Make sure copyKernels enabled if you're using zfs #78721
Conversation
| { | ||
| assertion = !config.boot.loader.grub.enable || config.boot.loader.grub.copyKernels; | ||
| message = "ZFS requires boot.loader.grub.copyKernels to be enabled"; | ||
| } |
There was a problem hiding this comment.
I don't think this needs to be an assertion. Just setting copyKernels to true if grub is enabled shouldn't be a problem.
There was a problem hiding this comment.
It could be potentially a breaking change for existing users with small boot partitions - do you think it's okay?
As a kinda data point, I have only 110M used on /boot* with boot.loader.grub.configurationLimit = 50; (while default is 100). So, it's a very small amount of data.
There was a problem hiding this comment.
Ah yeah an assertion sounds good then. Though I'd change the condition to
assertion = config.boot.loader.grub.enable -> config.boot.loader.grub.copyKernelsThere was a problem hiding this comment.
@infinisil @Ma27
It seems that due to the zfs enabled by default, there is no way to do a safe assertion (or I understand it in a wrong way). Right now, this assertion will basically mean that anyone who's using grub will need copyKernels to be enabled as well.
On the other hand, I searched a bit dipper and found that copyKernels will be effectively forced if /nix/store and boot path are on different filesystems [0]. Seems like it should be enough, but it makes copyKernels kind of impure.
There was a problem hiding this comment.
Would it work to check the actual fsType of /boot (or / if there is no separate /boot)?
(config.fileSystems."/boot" or config.fileSystems."/").fsType == "zfs"
There was a problem hiding this comment.
@chkno that's a good idea. Probably checking the root fs is enough as if it's zfs we should be already copying kernels as well as /boot doesn't always exist (for example, I have /boot[1-6]). I'll try a few different options and see how it'll work.
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
I would love to see this merged. |
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Bumping... |
stale
bot
removed
the
2.status: stale
stale
bot
added
the
2.status: stale
|
@magnetophon @maydayv7 if you want to see this merged, please create a new PR. The original author obviously doesn't want to pursue it anymore. |
Motivation for this change
The
boot.loader.grub.copyKernelsoption should be enabled if you're using ZFS. It's recommended in https://nixos.wiki/wiki/NixOS_on_ZFS anyways.Fix #60902
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)This change is