Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.behave: 1.2.6 -> 1.2.7.dev1, python3Packages.cucumber-tag-expressions: init at 3.0.0 #95914

Merged
merged 3 commits into from Aug 21, 2020
Merged

python3Packages.behave: 1.2.6 -> 1.2.7.dev1, python3Packages.cucumber-tag-expressions: init at 3.0.0 #95914

merged 3 commits into from Aug 21, 2020

Conversation

maxxk
Copy link
Contributor

@maxxk maxxk commented Aug 21, 2020

Motivation for this change

python3Packages.python-docx is broken in current master because behave 1.2.6 doesn't work in Python 3.8. Updated version is published as GitHub tag "1.2.7.dev1". However, there is no information about future release: behave/behave#855 .

This PR updates behave to version "1.2.7.dev1" and introduces its new dependency cucumber-tag-expressions.
Due to both behave and cucumber-tag-expressions dependency on pytest-html it is currently incompatible with Python 2.7, so I removed the compatibility code (patch and dependency) from behave package. If it is not desirable, I can rollback these changes, but recent version of pytest-html definitely is incompatible with Python 2.7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests 👍

7 packages built:
nrfutil python37Packages.behave python37Packages.cucumber-tag-expressions python37Packages.python-docx python38Packages.behave python38Packages.cucumber-tag-expressions python38Packages.python-docx

@jonringer jonringer merged commit cedbb56 into NixOS:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxxk @jonringer