Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iputils: 20190709 -> 20200821 #95922

Merged
merged 1 commit into from Aug 22, 2020
Merged

iputils: 20190709 -> 20200821 #95922

merged 1 commit into from Aug 22, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 21, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor

zowoq commented Aug 21, 2020

@ofborg eval

@ofborg ofborg bot requested a review from lheckemann August 21, 2020 23:41
@lheckemann lheckemann merged commit 9867918 into NixOS:master Aug 22, 2020
@vcunat
Copy link
Member

vcunat commented Aug 24, 2020

This broke a test and is blocking nixos-unstable channel. I don't know what's wrong ATM.

@lheckemann
Copy link
Member

Thanks for the hint, am looking into it.

@lheckemann
Copy link
Member

lheckemann commented Aug 24, 2020 •
edited

(removed detailed explanation of my findings so far, continue discussion in #96188)

@lheckemann lheckemann mentioned this pull request Aug 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@primeos @zowoq @vcunat @lheckemann