Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meguca: remove #95920

Merged
merged 1 commit into from Aug 21, 2020
Merged

meguca: remove #95920

merged 1 commit into from Aug 21, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 21, 2020

Motivation for this change

Has been broken since over a year.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Aug 21, 2020
Merged
10 tasks
jonringer
jonringer approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for cleanup.

If a full release went by, then I don't think anyone will miss this.

@kalbasit kalbasit merged commit 6f41415 into NixOS:master Aug 21, 2020
@Mic92 Mic92 deleted the meguca branch August 21, 2020 20:29
@06kellyjac
Copy link
Member

meguca is still in all-packages.nix and breaks nix-shell maintainers/scripts/update.nix --argstr maintainer blah's evaluation

https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L16274

@zowoq
Copy link
Contributor

zowoq commented Aug 21, 2020

Removed meguca from all-packages: 0447711

@kalbasit
Copy link
Member

@zowoq thanks for the quick fix. @06kellyjac good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mic92 @06kellyjac @zowoq @kalbasit @jonringer