Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/hardened: Port test to Python and fix it #95924

Merged
merged 2 commits into from Aug 23, 2020
Merged

nixos/hardened: Port test to Python and fix it #95924

merged 2 commits into from Aug 23, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Aug 21, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
nixos/testing: Fix fail() function
ff03800 
The docs say this behaves as succeed(), but it does not return stdout as
succeed() does. This fixes that behaviour
@dasJ
nixos/hardened: Port test to Python and fix it
540c033 
Related to NixOS#72828
Replaces and closes NixOS#76708

Looks like `nix ping-store` does not output anything anymore but still
fails when the connection does not work.
@dasJ dasJ requested review from joachifm and tfc as code owners August 21, 2020 19:36
@dasJ dasJ requested review from flokli and Br1ght0ne August 21, 2020 19:37
@dasJ
Copy link
Member Author

dasJ commented Aug 21, 2020

@GrahamcOfBorg test hardened

@flokli
Copy link
Contributor

flokli commented Aug 23, 2020

I hope nothing relies on the misdocumented fail() behaviour.

@flokli flokli merged commit c2a75a8 into NixOS:master Aug 23, 2020
@ajs124 ajs124 deleted the port/hardened-test branch August 23, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc approved these changes

@flokli flokli flokli approved these changes

@joachifm joachifm Awaiting requested review from joachifm joachifm is a code owner

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasJ @flokli @tfc