Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 148 and 142 #152

Merged
merged 2 commits into from Aug 21, 2020
Merged

fix 148 and 142 #152

merged 2 commits into from Aug 21, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Aug 21, 2020 •
edited

fixes #148
fixes #142

This change is Reviewable

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f402cf71b595b64f14c5d02--nixos-search.netlify.app

@garbas garbas merged commit e4fec33 into master Aug 21, 2020
@garbas garbas deleted the fix-148 branch August 21, 2020 20:23
@samueldr
Copy link
Member

Thre's a weird quirk in here:

This is for correctness' sake only, but this means that as an edge case you can produce links different to where you are currently in the app. Which gets hecking weird when you can accidentally produce such an URL:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expanding a search result triggers search Unable to select name
2 participants
@garbas @samueldr