Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris: 0.5.6 -> 0.5.7.1 #95906

Merged
merged 1 commit into from Aug 21, 2020
Merged

lutris: 0.5.6 -> 0.5.7.1 #95906

merged 1 commit into from Aug 21, 2020

Conversation

baracoder
Copy link
Contributor

Motivation for this change

Runner configuration dialogue was crashing with new wine versions, which seems fixed in 0.5.7.1
libgnome-keyring dependency is replaced with python keyring package (last change cc @jonringer )

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/95906
3 packages built:
lutris lutris-free lutris-unwrapped

@jonringer jonringer merged commit a770258 into NixOS:master Aug 21, 2020
@baracoder baracoder deleted the lutris-0_5_7_1 branch August 21, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baracoder @jonringer