Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio: add .desktop file #94821

Merged
merged 1 commit into from Aug 6, 2020
Merged

factorio: add .desktop file #94821

merged 1 commit into from Aug 6, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Aug 6, 2020

Motivation for this change

Add a desktop file for factorio.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member Author

mweinelt commented Aug 6, 2020

The icons are not yet showing for me in wofi.

@doronbehar
Copy link
Contributor

Why draft?

@mweinelt
Copy link
Member Author

mweinelt commented Aug 6, 2020

Why draft?

#94821 (comment)

piegamesde
piegamesde approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@piegamesde piegamesde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@mweinelt mweinelt marked this pull request as ready for review August 6, 2020 23:28
@mweinelt
Copy link
Member Author

mweinelt commented Aug 6, 2020

Works in rofi, doesn't work in wofi. Probably a wofi issue. 🤷

@mweinelt mweinelt merged commit 69b4099 into NixOS:master Aug 6, 2020
@mweinelt mweinelt deleted the factorio branch August 6, 2020 23:49
@priegger
Copy link
Contributor

I think this broke the *-headless builds.

@mweinelt
Copy link
Member Author

Ah, sorry we missed that. Guess we can move the steps into an alpha and demo specific installPhase.

@mweinelt mweinelt mentioned this pull request Aug 14, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piegamesde piegamesde piegamesde approved these changes

@Baughn Baughn Awaiting requested review from Baughn

@elitak elitak Awaiting requested review from elitak

@erictapen erictapen Awaiting requested review from erictapen

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mweinelt @doronbehar @priegger @piegamesde