Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chatty and feedbackd #94820

Closed
wants to merge 3 commits into from
Closed

Add Chatty and feedbackd #94820

wants to merge 3 commits into from

Conversation

masipcat
Copy link
Contributor

@masipcat masipcat commented Aug 6, 2020 •
edited

Motivation for this change

Use this amazing application from Librem

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@masipcat
Copy link
Contributor Author

masipcat commented Aug 6, 2020

Some screenshots:

image

image

@masipcat
Copy link
Contributor Author

masipcat commented Aug 6, 2020

Right now Chatty is built without any libpurple plugin and only works as a xmpp client. I'm not sure if we want to do something similar to pidgin-with-plugins. What do you think?

@masipcat
Copy link
Contributor Author

masipcat commented Aug 7, 2020

When this PR is merged the package calls can be update to latest version cc/ @craigem @lheckemann

@masipcat
Copy link
Contributor Author

Do you want to review this PR @jtojnar @flokli ? :)

@masipcat masipcat force-pushed the chatty-feedbackd branch 2 times, most recently from 5d9f980 to bde01ec Compare August 15, 2020 10:56
@masipcat
Copy link
Contributor Author

@jtojnar Fixed :)

@jtojnar
Copy link
Contributor

jtojnar commented Aug 15, 2020

Yeah, agree that we will need chatty-with-plugins. Also likely a module for feedbackd.

@masipcat
Copy link
Contributor Author

Also likely a module for feedbackd.

What do you mean?

@jtojnar
Copy link
Contributor

jtojnar commented Aug 15, 2020

Since it is a daemon, it probably requires installing by setting systemd.packages, services.dbus.packages NixOS options or something like that. NixOS module could handle that.

@masipcat
Copy link
Contributor Author

Added chatty-with-plugins. Successfully tested the following ones:

plugins = [ pkgs.pidgin-carbons pkgs.purple-lurch pkgs.telegram-purple ];

@jtojnar
Copy link
Contributor

jtojnar commented Aug 16, 2020

Looks like feedbackd does not seem to compile gsettings schemas. And also it does have a dbus service so it will not work without being installed globally (e.g. using a module).

@masipcat
Copy link
Contributor Author

Looks like feedbackd does not seem to compile gsettings schemas. And also it does have a dbus service so it will not work without being installed globally (e.g. using a module).

Working on a module + fixing gsettings!

jtojnar
jtojnar reviewed Aug 16, 2020
View reviewed changes
pkgs/top-level/aliases.nix
@@ -70,6 +70,7 @@ mapAliases ({
casperjs = throw "casperjs has been removed, it was abandoned by upstream and broken.";
catfish = xfce.catfish; # added 2019-12-22
cgmanager = throw "cgmanager was deprecated by lxc and therefore removed from nixpkgs."; # added 2020-06-05
chatty-with-plugins = chatty; # added 2020-08-16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add an legacy alias when this never existed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, we don't want an alias for the plugins or this file isn't the right place?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a reason for adding a longer name for chatty-with-plugins when chatty allows setting plugins argument too. Also this file is oriented more towards lesser aliases and can be disabled using allowAliases = false.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this. Aliases are for package renames/moves/etc.

@Pacman99 Pacman99 mentioned this pull request Dec 27, 2020
Merged
10 tasks
SuperSandro2000
SuperSandro2000 requested changes Dec 29, 2020
View reviewed changes
pkgs/top-level/aliases.nix
@@ -70,6 +70,7 @@ mapAliases ({
casperjs = throw "casperjs has been removed, it was abandoned by upstream and broken.";
catfish = xfce.catfish; # added 2019-12-22
cgmanager = throw "cgmanager was deprecated by lxc and therefore removed from nixpkgs."; # added 2020-06-05
chatty-with-plugins = chatty; # added 2020-08-16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this. Aliases are for package renames/moves/etc.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 94820 run on x86_64-linux 1

1 package failed to build:
  • chatty
1 package built:
  • feedbackd

chatty:

src/meson.build:60:0: ERROR: Dependency "libhandy-0.0" not found, tried pkgconfig

@dotlambda
Copy link
Member

@masipcat Are you still interested in working on this?

@jtojnar
Copy link
Contributor

jtojnar commented May 9, 2021

Feedbackd is now packaged. Jordi did not seem to respond on their other Librem related PR so feel free to revive chatty in a new PR.

@dotlambda dotlambda mentioned this pull request May 9, 2021
Merged
10 tasks
@dotlambda
Copy link
Member

closing in favor of #122373

@dotlambda dotlambda closed this May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@masipcat @jtojnar @SuperSandro2000 @dotlambda