New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blueberry: init at 1.3.9 #94819
blueberry: init at 1.3.9 #94819
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
it looks like it depends on bt-adapter, which is not installed on my system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this by running nix-shell -p blueberry
and then running blueberry
. It built ok, and the GUI loaded, but it kept outputting erros like this whenever I tried to do anything:
(blueberry.py:7813): com.linuxmint.blueberry-WARNING **: 14:33:19.022: Could not retrieve the BT adapter name with 'bt-adapter -i': Command '['timeout', '2s', 'bt-adapter', '-i']' returned non-zero exit status 127.
timeout: failed to run command ‘bt-adapter’: No such file or directory
bt-adapter
is in the bluez-tools
package. I don't think putting bluez-tools
in buildInputs
is sufficient to make its binaries accessible to blueberry at runtime. It looks like the bt-adapter
binary is quite central to this application (as opposed to an optional dependency where it might make sense to leave it up to the user to provide it), so it probably should be there. I'm not 100% sure what the correct solution is (manual substitution of absolute path? propagatedBuildInputs?)
propagatedBuildInputs won't do the trick. Either patching the paths, or add it in PATH in the wrapper. |
It works for me now. Not sure of the nuances, but would |
It does not require escaping, and prints a warning if no replacement is done, iirc. |
I have replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Motivation for this change
Add blueberry, a Bluetooth configuration tool.
It is Linux Mint's spin-off of GNOME Bluetooth, which works in all desktop environments.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)