Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gl2ps: make cmake a native build input #94815

Merged
merged 1 commit into from Aug 6, 2020
Merged

gl2ps: make cmake a native build input #94815

merged 1 commit into from Aug 6, 2020

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Aug 6, 2020 •
edited

Motivation for this change

Next piece in this pr. @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from 7c6f434c and twhitehead August 6, 2020 19:36
twhitehead
twhitehead approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@twhitehead twhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@worldofpeace worldofpeace merged commit c08a2bf into NixOS:master Aug 6, 2020
@matthuszagh matthuszagh deleted the gl2ps branch August 7, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twhitehead twhitehead twhitehead approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthuszagh @twhitehead @worldofpeace