Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency between a parameter name for AsyncFFSynchronizer and FFSynchronizer #467

Closed
ECP5-PCIe opened this issue Aug 6, 2020 · 5 comments
Closed

Inconsistency between a parameter name for AsyncFFSynchronizer and FFSynchronizer #467

ECP5-PCIe opened this issue Aug 6, 2020 · 5 comments
Labels
improvement
Milestone
0.3

Comments

@ECP5-PCIe
Copy link

The output domain parameter is o_domain for the synchronous one and domain for the asynchronous one
@awygle
Copy link
Contributor

awygle commented Aug 9, 2020

Since we haven't had a release since this was added, can I just fix this, or do I have to handle backwards-compat?

@whitequark
Copy link
Member

We can just fix this.

@whitequark
Copy link
Member

(But do we want to have o_domain everywhere rather than domain everywhere? I'm not sure...)

@awygle
Copy link
Contributor

awygle commented Aug 9, 2020

Agreed about the uncertainty but we can talk about that at some eventual meeting.

@whitequark
Copy link
Member

We decided to use o_domain for AsyncFFSynchronizer on the meeting.

@whitequark whitequark added this to the 0.3 milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Milestone
0.3
Development

No branches or pull requests
3 participants
@whitequark @awygle @ECP5-PCIe