Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk8: 1.8.0_242 -> 1.8.0_265 #94789

Merged
merged 1 commit into from Aug 7, 2020
Merged

openjdk8: 1.8.0_242 -> 1.8.0_265 #94789

merged 1 commit into from Aug 7, 2020

Conversation

jerith666
Copy link
Contributor

Note that a -ga tag hasn't appeared in the aarch64 repo, so I had to use b01. :-/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edwtjo and NeQuissimus August 6, 2020 13:49
@NeQuissimus
Copy link
Member

Is this the same as #94573 ?

@jerith666
Copy link
Contributor Author

Yep. cc @asbachb .

@asbachb
Copy link
Contributor

asbachb commented Aug 6, 2020

It seems that you got the aarch64 hashes right. So let's usw this one instead of mine.

@NeQuissimus NeQuissimus merged commit b71dc9d into NixOS:master Aug 7, 2020
@asbachb
Copy link
Contributor

asbachb commented Aug 7, 2020

I guess we should backport this to 20.03 as well.

@NeQuissimus
Copy link
Member

@asbachb Would you be able to do that for me? :) Thx!

@asbachb
Copy link
Contributor

asbachb commented Aug 7, 2020

@NeQuissimus

8: #94868
11: #94603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerith666 @NeQuissimus @asbachb