Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/postgresql: fix setup script #94805

Merged
merged 1 commit into from Aug 6, 2020
Merged

nixos/postgresql: fix setup script #94805

merged 1 commit into from Aug 6, 2020

Conversation

bachp
Copy link
Member

@bachp bachp commented Aug 6, 2020

Motivation for this change

After #94454 postgresql didn't start up on my machine anymore.

After some analysis I think the missing () caused parts of the setup script to be added to the
ExecStartPost line instead of inside the script.

This caused postgresql start to fail under certain conditions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp
nixos/postgresql: fix setup script
cee4e14 
The missing () caused parts of the escripts to be added to the
ExecStartPost line instead of inside the script.

This caused postgresql start to fail under certain conditions.
@flokli flokli requested a review from aanderse August 6, 2020 18:06
aanderse
aanderse approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bachp sorry for the hassle. I'm a bit confused how the test successfully completed with this mistake... 🤔 Thanks for catching and fixing 👍

@aanderse
Copy link
Member

aanderse commented Aug 6, 2020

@GrahamcOfBorg test postgresql postgresql-wal-receiver

@flokli flokli merged commit d7f0530 into NixOS:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachp @aanderse @flokli