Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.timepp: unstable-2019-03-30 -> unstable-2020-03-15 #94771

Merged
merged 1 commit into from Sep 19, 2020
Merged

gnomeExtensions.timepp: unstable-2019-03-30 -> unstable-2020-03-15 #94771

merged 1 commit into from Sep 19, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Aug 6, 2020 •
edited

Motivation for this change

This update is supposed to unbreak the package.

Things done

I didn't test the extension yet. I'll do it soon.

3.32 failed to load with the latest Gnome.

2020-03-15 loads but there seem to be a bunch of bugs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/kx1qhzmpffzpib6ivvbqjvrs1db1v767-gnome-shell-extension-timepp-3.32 35.8M

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 6, 2020
@bbigras bbigras changed the title gnomeExtensions.timepp: unstable-2019-03-30 -> 3.32 gnomeExtensions.timepp: unstable-2019-03-30 -> unstable-2020-03-15 Aug 6, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Aug 25, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 25, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/279

@worldofpeace worldofpeace merged commit dff40ce into NixOS:master Sep 19, 2020
@worldofpeace
Copy link
Contributor

Could you backport to 20.09?

@bbigras
Copy link
Contributor Author

bbigras commented Sep 19, 2020

Done. #98287

Thanks!

@bbigras bbigras deleted the timepp branch September 19, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @nixos-discourse @worldofpeace