Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinygo: include files from gen-device #94794

Closed
wants to merge 1 commit into from
Closed

tinygo: include files from gen-device #94794

wants to merge 1 commit into from

Conversation

yvesf
Copy link
Member

@yvesf yvesf commented Aug 6, 2020

Motivation for this change

fix #94793

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Chiiruno and kalbasit August 6, 2020 14:46
@yvesf
Copy link
Member Author

yvesf commented Aug 6, 2020

Unfortunately, building a binary for an nrf-based board is still failing:

$ tinygo build -target=microbit -o test
error: failed to build /nix/store/dlas998iig5xgmllr25kl5y97kfa35p5-tinygo-0.13.1/share/tinygo/lib/compiler-rt/lib/builtins/absvdi2.c: none of these commands were found in your $PATH: clang-10

Tinygo tries to find find clang under the name clang-10. If I patch this to also try just clang it fails with:

$ tinygo build -target=microbit -o test
clang-10: error: argument unused during compilation: '-nostdlibinc' [-Werror,-Wunused-command-line-argument]
clang-10: error: argument unused during compilation: '--gcc-toolchain=/nix/store/b3zsk4ihlpiimv3vff86bb5bxghgdzb9-gcc-9.2.0' [-Werror,-Wunused-command-line-argument]
error: failed to build /nix/store/vd8hhfnr22kmv0b8szlbpd4yj4sj3q9g-tinygo-0.13.1/share/tinygo/lib/compiler-rt/lib/builtins/absvdi2.c: exit status 1```

@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 29, 2020 04:31
@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@muscaln
Copy link
Contributor

muscaln commented Sep 15, 2022

Closing as it's fixed.

@muscaln muscaln closed this Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tinygo does not contain files from gen-device
3 participants
@yvesf @muscaln @SuperSandro2000