Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord: 0.0.10 -> 0.0.11 #94811

Merged
merged 1 commit into from Aug 6, 2020
Merged

discord: 0.0.10 -> 0.0.11 #94811

merged 1 commit into from Aug 6, 2020

Conversation

ldesgoui
Copy link
Contributor

@ldesgoui ldesgoui commented Aug 6, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ldesgoui ldesgoui mentioned this pull request Aug 6, 2020
Closed
jonringer
jonringer approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 94811 1

1 package built: - discord

@jonringer jonringer merged commit ded6c3d into NixOS:master Aug 6, 2020
@KamilaBorowska
Copy link
Member

Could this be backported to 20.03?

@jonringer
Copy link
Contributor

yes, doing a follow up really quick

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 6, 2020
This was referenced Aug 6, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldesgoui @KamilaBorowska @jonringer