Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[taskcluster] Schedule Chrome Nightly epochs/daily #24904

Merged
merged 1 commit into from Aug 6, 2020

Conversation

Hexcles
Copy link
Member

@Hexcles Hexcles commented Aug 6, 2020

as well as triggers/chrome_nightly

The task will install Chromium ToT automatically.

as well as triggers/chrome_nightly

The task will install Chromium ToT automatically.
@Hexcles
Copy link
Member Author

Hexcles commented Aug 6, 2020

Currently running on triggers/chrome_nightly: https://community-tc.services.mozilla.com/tasks/groups/HvbHQp7cTjW-46_3A15wHw

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Aug 6, 2020

It looks like this is generating the wrong WPT command line for wpt-chrome-dev-results-without-changes?

From https://github.com/web-platform-tests/wpt/pull/24904/checks?check_run_id=954285882, emphasis mine:

python ./wpt run dev --channel=dev --no-fail-on-unexpected --log-wptreport=../artifacts/wpt_report.json --log-wptscreenshot=../artifacts/wpt_screenshot.txt --affected task_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full chrome

@Hexcles
Copy link
Member Author

Hexcles commented Aug 6, 2020

This is really weird. Locally, running the same command from https://community-tc.services.mozilla.com/tasks/d1jQlw5UTNmG2A2-5kE1oA/runs/0/logs/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2Fd1jQlw5UTNmG2A2-5kE1oA%2Fruns%2F0%2Fartifacts%2Fpublic%2Flogs%2Flive.log#L321

I got

Executing command: python ./wpt run --channel=dev --no-fail-on-unexpected --log-wptreport=../artifacts/wpt_report.json --log-wptscreenshot=../artifacts/wpt_screenshot.txt --affected task_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full chrome

It seems as if the change in taskcluster-run.py wasn't picked up.

@Hexcles
Copy link
Member Author

Hexcles commented Aug 6, 2020

Oh sorry. This only happens in "without-changes", which of course does not have my change, so this is expected.

Copy link
Contributor

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah of course, sorry I should have realized -_-.

LGTM, but please confirm with @jgraham that we have resources for another daily runner.

@Hexcles
Copy link
Member Author

Hexcles commented Aug 6, 2020

Right, by the way, this doesn't have to be daily. A weekly run perhaps also suffices for now.

@jgraham
Copy link
Contributor

jgraham commented Aug 6, 2020

No objections from me.

@Hexcles
Copy link
Member Author

Hexcles commented Aug 6, 2020

Thanks! Admin-merging, ignoring the without-changes failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants