Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electrum: 3.3.8 -> 4.0.2 #94797

Merged
merged 1 commit into from Aug 8, 2020
Merged

electrum: 3.3.8 -> 4.0.2 #94797

merged 1 commit into from Aug 8, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Aug 6, 2020 •
edited

Motivation for this change

New major update; changelog: https://github.com/spesmilo/electrum/blob/master/RELEASE-NOTES

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested review from mmahut and 1000101 August 6, 2020 15:44
@ofborg ofborg bot requested review from np, ehmry and joachifm August 6, 2020 15:50
@1000101
Copy link
Member

1000101 commented Aug 7, 2020

@GrahamcOfBorg build electrum

1000101
1000101 approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@1000101 1000101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • ran nix-review without any failures
  • ran and tested the binaries

@ehmry ehmry merged commit 5d22e3c into NixOS:master Aug 8, 2020
@prusnak prusnak deleted the electrum-4 branch August 8, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000101 1000101 1000101 approved these changes

@mmahut mmahut Awaiting requested review from mmahut

@np np Awaiting requested review from np

@ehmry ehmry Awaiting requested review from ehmry

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @1000101 @ehmry