Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Apprainbarf: init at 1.4 #95872

Merged
merged 1 commit into from Aug 22, 2020
Merged

perlPackages.Apprainbarf: init at 1.4 #95872

merged 1 commit into from Aug 22, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 20, 2020 •
edited

Motivation for this change

A perl package I love, please let this get into nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested review from volth and stigtsp August 20, 2020 21:49
stigtsp
stigtsp reviewed Aug 20, 2020
View reviewed changes
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
stigtsp
stigtsp requested changes Aug 21, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make rainbarf run on darwin:

    nativeBuildInputs = stdenv.lib.optional stdenv.isDarwin shortenPerlShebang;
    postInstall = stdenv.lib.optionalString stdenv.isDarwin ''
      shortenPerlShebang $out/bin/rainbarf
    '';

@saschagrunert
Copy link
Member Author

Thank you for the kind review! 🙏 I added the suggested changes, please take a look again. :)

stigtsp
stigtsp requested changes Aug 21, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls change commit message to perlPackages.Apprainbarf: init at 1.4

@saschagrunert
perlPackages.Apprainbarf: init at 1.4
1683f3a 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

Pls change commit message to perlPackages.Apprainbarf: init at 1.4

Done, thank you for the hint 👍

stigtsp
stigtsp approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thx for the PR

(To be pedantic: maybe update the PR name as well)

@saschagrunert saschagrunert changed the title rainbarf: init at 1.4 perlPackages.Apprainbarf: init at 1.4 Aug 21, 2020
@stigtsp stigtsp requested a review from aanderse August 21, 2020 10:26
@stigtsp
Copy link
Member

stigtsp commented Aug 21, 2020

@GrahamcOfBorg build perlPackages.Apprainbarf

@aanderse
Copy link
Member

@stigtsp I'm sure one day we'll get the bot building darwin for you...
@GrahamcOfBorg build perlPackages.Apprainbarf

@aanderse
Copy link
Member

Sounds like @stigtsp tested this on darwin so we'll go with that.

@aanderse aanderse merged commit 767bf2f into NixOS:master Aug 22, 2020
@saschagrunert saschagrunert deleted the rainbarf branch August 22, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschagrunert @stigtsp @aanderse