Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs26: install correct emacs version #95877

Closed
wants to merge 1 commit into from
Closed

emacs26: install correct emacs version #95877

wants to merge 1 commit into from

Conversation

turboMaCk
Copy link
Member

Closes #95876

In #95169 Emacs was updated to version 27.
however this also changed the explicit emacs26 attribute.

This PR checks back expressions for building Emacs 26 under emacs26
attribute.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turboMaCk
emacs26: install correct emacs version
d123986 
In NixOS#95169 Emacs was updated to version 27.
however this also changed the explicit emacs26 attribute.

This PR checks back expressions for building Emacs 26 under `emacs26`
attribute.
@turboMaCk
Copy link
Member Author

This is ready @lovek323 @peti @jwiegley @adisbladis

turboMaCk added a commit to turboMaCk/Dotfiles that referenced this pull request Aug 20, 2020
@turboMaCk
Add emacs26 overlay
c6b0775 
Applies fix from NixOS/nixpkgs#95877
@adisbladis
Copy link
Member

@turboMaCk Thanks for this PR.
I would however like to avoid full copies of essentially the same expression so I've made
#95878 instead.

@adisbladis
Copy link
Member

Closing this in favour of #95878.

@adisbladis adisbladis closed this Aug 20, 2020
@turboMaCk turboMaCk deleted the fix-emacs-26 branch February 2, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis adisbladis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

emacs26 is in fact emacs27
2 participants
@turboMaCk @adisbladis