Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/fontconfig: fix local.conf regression #95869

Merged
merged 1 commit into from Aug 20, 2020
Merged

nixos/fontconfig: fix local.conf regression #95869

merged 1 commit into from Aug 20, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 20, 2020

Motivation for this change

Another part of edf2541 was missed while
rebasing #93562, resulting in incorrect path
as described by #86601 (comment)

cc @flokli @isaacwhanson

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
nixos/fontconfig: fix local.conf regression
fe1b9eb 
Another part of edf2541 was missed while
rebasing NixOS#93562, resulting in incorrect path
as described by NixOS#86601 (comment)
@arizonahanson
Copy link

@jtojnar thank you

@jtojnar jtojnar merged commit 2adf17f into NixOS:master Aug 20, 2020
@jtojnar jtojnar deleted the fc-local-regression branch August 20, 2020 21:43
@flokli
Copy link
Contributor

flokli commented Aug 21, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @arizonahanson @flokli @worldofpeace