Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valo: init at 0.2.2 #95871

Closed
wants to merge 1 commit into from
Closed

valo: init at 0.2.2 #95871

wants to merge 1 commit into from

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Aug 20, 2020

Motivation for this change

A Program to Control Backlights (and other Hardware Lights) in GNU/Linux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes Aug 22, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not typical to make a NixOS module that just installs a package. So I suggest dropping the module.

@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 22, 2020

@ryantm Thanks for the review!

We add the module because we want to configure a setcap wrapper for valo (security.wrappers.valo.source = "${pkgs.valo.out}/bin/valo").

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 29, 2020 •
edited

Result of nixpkgs-review pr 95871 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • valo

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
pkgs/os-specific/linux/valo/default.nix
description =
"A Program to Control Backlights (and other Hardware Lights) in GNU/Linux";
homepage = https://github.com/xrelkd/valo;
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpl3Only or gpl3Plus?

@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@xrelkd xrelkd closed this Jul 25, 2021
@xrelkd xrelkd deleted the add/valo branch February 2, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @SuperSandro2000 @ryantm