sommelier: init at 2020-08-10-be4e16f #95874

offlinehacker · 2020-08-20T20:47:09Z

Things done

offlinehacker · 2020-08-20T20:50:17Z

colemickens · 2020-08-20T21:05:09Z

What are you doing with it? (just curious!)

offlinehacker · 2020-08-20T21:07:35Z

For testing:

sommelier --master  --display=wayland-0 --socket=wayland-1
sommelier -X --display=wayland-1 xterm

I am still getting following errors:

xdg_surface@61: error 3: xdg_surface has never been configured

This is most likely to be fixed with: https://patches.videolan.org/patch/20875/

offlinehacker · 2020-08-20T21:10:22Z

@colemickens using for lightweight secure dev environments, have several iterations how i want to test it (locally with multiple users sharing same root compositor, docker dev containers, kata containers, just a few ideas)

offlinehacker · 2020-08-20T21:11:59Z

@colemickens thanks for initial package

colemickens · 2020-08-20T21:14:23Z

@offlinehacker I'm very interested in those use-cases, I'd love to know if you get cool stuff working. You might be interested in https://spectrum-os.org/ and #spectrum on freenode if you're not already familiar.

@offlinehacker also, no worries, I didn't know any of it was useful. I think I had (tried to?) implemented xdg stable but never got anything to actually work...

offlinehacker · 2020-08-20T21:15:44Z

I was also trying with drm support using:

sommelier --master  --display=wayland-0 --socket=wayland-1 --shm-driver=dmabuf --drm-device=/dev/dri/card0
sommelier --display=wayland-1 alacritty

Getting these errors:

MESA-LOADER: failed to open iris (search paths /run/opengl-driver/lib/dri)
failed to load driver: iris
MESA-LOADER: failed to open kms_swrast (search paths /run/opengl-driver/lib/dri)
failed to load driver: kms_swrast
MESA-LOADER: failed to open swrast (search paths /run/opengl-driver/lib/dri)
failed to load swrast driver
error: couldn't get display device

I have iris driver, but i did not dig too much yet, why it does not work.

alyssais · 2020-08-20T22:22:11Z

Does my Sommelier package work? chromiumOSPackages.sommelier in https://spectrum-os.org/git/nixpkgs

offlinehacker · 2020-08-21T09:02:02Z

@colemickens I found out about spectrum-os when packaging sommelier and from what I was reading from @alyssais posts on mailing list it looks like absolutely awesome project. I still need a bit more research (reading of @alyssais weekly updates), whether it aligns with what I want to accomplish and I might join to contribute.

@alyssais I was testing it, and it works, but I think I had issue when running in master mode, it needed to have wayland device. I worked around this by overriding it to NULL. Also Google has updated sources to use stable xdg shell now, so it does not need patches anymore. I would also prefer for nixpkgs to package sommelier from "official" source.

alyssais · 2020-08-22T12:53:59Z

@alyssais I was testing it, and it works, but I think I had issue when running in master mode, it needed to have wayland device. I worked around this by overriding it to NULL. Also Google has updated sources to use stable xdg shell now, so it does not need patches anymore. I would also prefer for nixpkgs to package sommelier from "official" source.

Oh, cool! That's good to know. Not sure what you mean about "official" source -- I fetch from Google Gitiles just as you do.

alyssais · 2020-08-22T14:03:09Z

pkgs/tools/wayland/sommelier/default.nix

+    "-Dshm_driver=noop"
+  ];
+
+  NIX_CFLAGS_COMPILE = ["-DVIRTWL_DEVICE=NULL"];


What’s your use case for Sommelier if you’re not using it with virtio wayland? it would feel very weird to be to package Sommelier without virtio wayland Support since that’s (to me at least) its most compelling feature.

One example would be running sommelier in linux container and let it use your system wayland compositor. This way processes in container can use sommelier for wayland compositon, instead of directly connecting to system wayland, thus providing extra layer of security.

offlinehacker · 2020-08-25T19:25:54Z

Not sure what you mean about "official"
source -- I fetch from Google Gitiles just as you do.

Sorry I have mistaken with this fork from @colemickens https://github.com/colemickens/platform2-sommelier

offlinehacker · 2020-08-25T19:32:17Z

Looks like they just reverted the update to stable version of xdg shell, probably the same issues with xdg_surface. https://chromium.googlesource.com/chromiumos/platform2/+/32050c0ea6c00c16999915856b40a6a6b8b41bb9

SuperSandro2000 · 2021-01-18T12:18:18Z

pkgs/tools/wayland/sommelier/default.nix

+  };
+  setSourceRoot="sourceRoot=$(echo platform2-*/vm_tools/sommelier)";
+
+  nativeBuildInputs = [ pkgconfig meson ninja ]


Suggested change

nativeBuildInputs = [ pkgconfig meson ninja ]

nativeBuildInputs = [ pkg-config meson ninja ]

SuperSandro2000 · 2021-01-18T12:18:22Z

pkgs/tools/wayland/sommelier/default.nix

+  setSourceRoot="sourceRoot=$(echo platform2-*/vm_tools/sommelier)";
+
+  nativeBuildInputs = [ pkgconfig meson ninja ]
+    ++ stdenv.lib.optional buildDocs scdoc;


Suggested change

++ stdenv.lib.optional buildDocs scdoc;

++ lib.optional buildDocs scdoc;

SuperSandro2000 · 2021-01-18T12:18:45Z

pkgs/tools/wayland/sommelier/default.nix

+
+  enableParallelBuilding = true;


Suggested change

enableParallelBuilding = true;

set by cmake.

SuperSandro2000 · 2021-01-18T12:18:51Z

pkgs/tools/wayland/sommelier/default.nix

+
+  enableParallelBuilding = true;
+
+  meta = with stdenv.lib; {


Suggested change

meta = with stdenv.lib; {

meta = with lib; {

stale · 2021-07-21T02:12:12Z

I marked this as stale due to inactivity. → More info

Since virtio-gpu context types are now in upstream kernels, it is now possible to use Sommelier without patching it or using custom kernels, so I think it's finally suitable for inclusion in Nixpkgs. I'm using the same versioning scheme I made up for crosvm here. Figuring out the version is handled by the update script, which I adapted from the crosvm one. Sadly there's too many differences between them to easily merge them into one, so reducing duplication between them is left as further work. Closes: NixOS#95874

Since virtio-gpu context types are now in upstream kernels, it is now possible to use Sommelier without patching it or using custom kernels, so I think it's finally suitable for inclusion in Nixpkgs. I'm using the same versioning scheme I made up for crosvm here. Figuring out the version is handled by the update script, which I adapted from the crosvm one. Sadly there's too many differences between them to easily merge them into one, so reducing duplication between them is left as further work. Closes: #95874

sommelier: init at 2020-08-10-be4e16f

f08e7f3

offlinehacker requested review from colemickens and alyssais August 20, 2020 20:47

alyssais requested a review from puckipedia August 20, 2020 22:25

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 21, 2020

alyssais reviewed Aug 22, 2020

View reviewed changes

SuperSandro2000 requested changes Jan 18, 2021

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021

alyssais mentioned this pull request Aug 5, 2022

sommelier: init at 104.0 #185251

Merged

13 tasks

alyssais closed this in #185251 Aug 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sommelier: init at 2020-08-10-be4e16f #95874

sommelier: init at 2020-08-10-be4e16f #95874

offlinehacker commented Aug 20, 2020

offlinehacker commented Aug 20, 2020

colemickens commented Aug 20, 2020 •

edited

offlinehacker commented Aug 20, 2020

offlinehacker commented Aug 20, 2020

offlinehacker commented Aug 20, 2020

colemickens commented Aug 20, 2020

offlinehacker commented Aug 20, 2020

alyssais commented Aug 20, 2020

offlinehacker commented Aug 21, 2020

alyssais commented Aug 22, 2020 via email

alyssais Aug 22, 2020

offlinehacker Aug 25, 2020

offlinehacker commented Aug 25, 2020

offlinehacker commented Aug 25, 2020 •

edited

SuperSandro2000 Jan 18, 2021

SuperSandro2000 Jan 18, 2021

SuperSandro2000 Jan 18, 2021

SuperSandro2000 Jan 18, 2021

stale bot commented Jul 21, 2021

	nativeBuildInputs = [ pkgconfig meson ninja ]
	nativeBuildInputs = [ pkg-config meson ninja ]

	++ stdenv.lib.optional buildDocs scdoc;
	++ lib.optional buildDocs scdoc;

sommelier: init at 2020-08-10-be4e16f #95874

sommelier: init at 2020-08-10-be4e16f #95874

Conversation

offlinehacker commented Aug 20, 2020

Things done

offlinehacker commented Aug 20, 2020

colemickens commented Aug 20, 2020 • edited

offlinehacker commented Aug 20, 2020

offlinehacker commented Aug 20, 2020

offlinehacker commented Aug 20, 2020

colemickens commented Aug 20, 2020

offlinehacker commented Aug 20, 2020

alyssais commented Aug 20, 2020

offlinehacker commented Aug 21, 2020

alyssais commented Aug 22, 2020 via email

alyssais Aug 22, 2020

Choose a reason for hiding this comment

offlinehacker Aug 25, 2020

Choose a reason for hiding this comment

offlinehacker commented Aug 25, 2020

offlinehacker commented Aug 25, 2020 • edited

SuperSandro2000 Jan 18, 2021

Choose a reason for hiding this comment

SuperSandro2000 Jan 18, 2021

Choose a reason for hiding this comment

SuperSandro2000 Jan 18, 2021

Choose a reason for hiding this comment

SuperSandro2000 Jan 18, 2021

Choose a reason for hiding this comment

stale bot commented Jul 21, 2021

colemickens commented Aug 20, 2020 •

edited

offlinehacker commented Aug 25, 2020 •

edited