Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oneDNN: disable tests to avoid illegal instructions #94220

Merged
merged 1 commit into from Aug 1, 2020
Merged

oneDNN: disable tests to avoid illegal instructions #94220

merged 1 commit into from Aug 1, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

oneDNN tests fail on some Hydra builders because they do not support SSE
4.2. Unfortunately, oneDNN does not seem to work without SSE 4.2, see
issues #93692 and #93747.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
oneDNN: disable tests to avoid illegal instructions
2598f0e 
oneDNN tests fail on some Hydra builders because they do not support SSE
4.2. Unfortunately, oneDNN does not seem to work without SSE 4.2, see
issues NixOS#93692 and NixOS#93747.
@ofborg ofborg bot requested review from alexarice and bhipple July 30, 2020 08:40
@danieldk danieldk merged commit 84a8b4d into NixOS:master Aug 1, 2020
@danieldk danieldk deleted the onednn-disable-tests branch August 1, 2020 06:31
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/supported-instruction-sets/10755/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@alexarice alexarice Awaiting requested review from alexarice

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @nixos-discourse @bhipple