Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.17.0 -> 1.18.0 #94237

Merged
merged 1 commit into from Jul 31, 2020
Merged

matrix-synapse: 1.17.0 -> 1.18.0 #94237

merged 1 commit into from Jul 31, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jul 30, 2020 •
edited

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.18.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jul 30, 2020
@Ma27 Ma27 merged commit 8738de2 into NixOS:master Jul 31, 2020
@Ma27 Ma27 deleted the bump-matrix-synapse branch July 31, 2020 12:23
@Ma27
Copy link
Member Author

Ma27 commented Jul 31, 2020

Ported to stable as c9f5211

@Atemu
Copy link
Member

Atemu commented Jul 31, 2020

Any idea why ofBorg sent me an email with this?

I have no connection to this PR, the supposedly failed check is unnamed and ...what? I'm confused.

@Ma27
Copy link
Member Author

Ma27 commented Jul 31, 2020

No idea, but this seems like a misconfigured GH Actions in this rep: https://github.com/NixOS/nixpkgs/actions

@Ma27
Copy link
Member Author

Ma27 commented Jul 31, 2020

@Atemu just asked in #nixos-dev if someone is aware of that %)

@Atemu
Copy link
Member

Atemu commented Jul 31, 2020

Okay, it's spamming me with all kinds of PRs now, the issue is not specific to this one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadenb fadenb fadenb approved these changes

@mguentner mguentner Awaiting requested review from mguentner

@Ralith Ralith Awaiting requested review from Ralith

@Ekleog Ekleog Awaiting requested review from Ekleog

@pacien pacien Awaiting requested review from pacien

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @Atemu @fadenb