Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nano: 4.9.3 -> 5.0 #94221

Merged
merged 1 commit into from Jul 31, 2020
Merged

nano: 4.9.3 -> 5.0 #94221

merged 1 commit into from Jul 31, 2020

Conversation

lsix
Copy link
Member

@lsix lsix commented Jul 30, 2020

Motivation for this change

https://lists.gnu.org/archive/html/info-gnu/2020-07/msg00010.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from joachifm July 30, 2020 10:05
prusnak
prusnak approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works. Including nix syntax highlighting.

jonringer
jonringer approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why some of these depend on nano, but
diff LGTM
launches fine

https://github.com/NixOS/nixpkgs/pull/94221
1 package marked as broken and skipped:
rssh

2 packages blacklisted:
tests.nixos-functions.nixos-test tests.nixos-functions.nixosTest-test

13 packages built:
cabal2nix crip cvs cvs2svn cvs_fast_export cvsps cvsq dep2nix nano nix-prefetch-cvs nix-prefetch-scripts nix-update-source reposurgeon

@jonringer jonringer merged commit 7bec3a3 into NixOS:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@jonringer jonringer jonringer approved these changes

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lsix @prusnak @jonringer