cmake-language-server: fix test error on macOS #94213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix Hydra's Darwin test failures for this package. See regen100/cmake-language-server#24
r-burns
force-pushed
the
cmake-language-server
branch
from
f551786
to
1f67443
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 0
labels
marsam
reviewed
Jul 30, 2020
| @@ -15,6 +16,12 @@ buildPythonApplication rec { | |||
| sha256 = "0vz7bjxkk0phjhz3h9kj6yr7wnk3g7lqmkqraa0kw12mzcfck837"; | |||
| }; | |||
|
|
|||
| # can be removed after v0.1.2 | |||
| patches = stdenv.lib.optional stdenv.isDarwin (fetchpatch { | |||
| url = "https://github.com/regen100/cmake-language-server/pull/24.patch"; | |||
There was a problem hiding this comment.
please use the specific commit
Suggested change
| url = "https://github.com/regen100/cmake-language-server/pull/24.patch"; | |
| url = "https://github.com/regen100/cmake-language-server/commit/0ec120f39127f25898ab110b43819e3e9becb8a3.patch"; |
kira-bruneau
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
I don't have a mac to test this on, but this looks good to me. Thanks @r-burns!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This should fix Hydra's Darwin test failures for this package.
See regen100/cmake-language-server#24
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)