Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Service depot also reset breakdown chance. #8286

Closed
wants to merge 1 commit into from
Closed

Change: Service depot also reset breakdown chance. #8286

wants to merge 1 commit into from

Conversation

Galigator
Copy link
Contributor

I have so mush fun with this little change, that I really what to share it.
I have found the idea on Openttd forum.

Each time your vehicle go to service, then the breakdown chance is reset.
It allow to create large trains networks with simple tracks but carefully timed service and length to it.

Regards.

@nielsmh
Copy link
Contributor

nielsmh commented Jul 30, 2020

Hm so with this change, when you're playing with reduced breakdowns, vehicles will never break down right after receiving service?

@James103
Copy link
Contributor

Suggested commit message (grammar fix): "Change: Service at depot resets breakdown chance"

@ldpl
Copy link
Contributor

ldpl commented Jul 30, 2020

This is just the same as the vehicle breaking down, doesn't protect it from further breakdowns completely, only makes it less likely for a while.

Though, I guess in some cases it makes it so much less likely that it's effectively 0.

@Galigator
Copy link
Contributor Author

Yes you have too think it a bit like "predictive maintenance". If you do it well, everything goes well, if you start jamming your network sometime everything will go badly wrong after a while. Smoothness is require to operate an interconnection. Also train waiting in depot for an route, still start raise there breakdown chance, so your buffers must be carefully crafted; but you don't have to do silly/made network with logic to handle breakdown, or disable breakdown.
It just make it playable.

https://www.reddit.com/r/openttd/comments/4szlhj/an_easy_solution_for_fixing_breakdowns/

@@ -170,6 +170,8 @@ void VehicleServiceInDepot(Vehicle *v)
v->reliability = v->GetEngine()->reliability;
/* Prevent vehicles from breaking down directly after exiting the depot. */
v->breakdown_chance /= 4;
if (_settings_game.difficulty.vehicle_breakdowns == 1) // reduced breakdown.
v->breakdown_chance = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style: Single line or {}

@Galigator
Copy link
Contributor Author

#8317 correct and replace this PR.

@Galigator Galigator closed this Sep 25, 2020
@michicc
Copy link
Member

michicc commented Sep 25, 2020

Administrative note: A forced push to the old branch to update this PR would have been preferable, but this PR is small enough, so don't worry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants