mailnag: enable to configure plugins #94202
Conversation
Add an availablePlugins attrset with all plugins available. Make mailnag's expression accept a "plugins" argument specifying plugins to install, from `availablePlugins`. Prevent double wrapping (nor related to plugins). Install plugins using xorg.lndir.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/issues-with-gnome-keyring-and-libsecret/8370/2 |
|
Since changing from the 1.3.0 to the 2.0.0 mailnag release, I have been unable save my mail passwords between log ins. |
I don't experience this and this is unrelated. Let's discuss this at https://discourse.nixos.org/t/issues-with-gnome-keyring-and-libsecret/8370/ :). |
|
Sorry for my previous entry. I should not have posted here. Things were resolved on the discourse link given above. |
|
@jonringer I hope it'd be OK to ask you for a review directly, considering you are busy with the release. This one has a large diff due to some refactoring, and I think that's why reviewers haven't gave it a look. Additionally, it's a Python package I edited and added, so it should be also your area of expertise. |
There was a problem hiding this comment.
since it's just one plugin, i think this is fine.
If more are added, it might be worthwhile to refactor it so that it's a little easier to bring in plugins (e.g. plugins = callPackage ./plugins.nix )
https://github.com/NixOS/nixpkgs/pull/94202
1 package built:
mailnag
Maybe it'll be best to do take care of this now - The last push makes it possible to override the set of available plugins. |
or maybe do something like: |
|
@jonringer I haven't to implement exactly the |
There was a problem hiding this comment.
I think this is good.
It would be preferable to have it do something like a symlinkJoin all the packages into a new derivation, so you don't have to rebuild mailnag. But that's way more involved, and since it will use the same mailnag.withPackages convention, that can be done at a later time.
https://github.com/NixOS/nixpkgs/pull/94202
2 packages built:
mailnag mailnagWithPlugins
|
Thanks 🎸. |
Motivation for this change
Make mailnag more usable for Gnome users - make the gnome online accounts mailnag extension usable via Nix arguments to the derivation. Mailnag's Goa plugin is https://github.com/pulb/mailnag-goa-plugin . This PR also makes it easy enough for future us add other plugins that will be added to the derivation.
Things done
See commit message. I'm currently using it and it works great for me + plus the gnome shell extension: https://extensions.gnome.org/extension/886/mailnag/
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)