Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_11: start with 11.0.0rc2 #94204

Closed
wants to merge 7 commits into from
Closed

llvmPackages_11: start with 11.0.0rc2 #94204

wants to merge 7 commits into from

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Jul 30, 2020 •
edited

http://lists.llvm.org/pipermail/release-testers/2020-August/001321.html
http://lists.llvm.org/pipermail/release-testers/2020-July/001305.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from 7c6f434c, dtzWill and lovek323 July 30, 2020 00:51
@ggreif
Copy link
Contributor Author

ggreif commented Jul 30, 2020

@GrahamcOfBorg build lldb_11

@ggreif
Copy link
Contributor Author

ggreif commented Aug 3, 2020

Yes, removing .patch files next.

@ggreif
Copy link
Contributor Author

ggreif commented Aug 3, 2020 •
edited

I get

CMake Error at CMakeLists.txt:4 (message):
  libc++abi now requires being built in a monorepo layout with libcxx
  available

On macOS.

@primeos
Copy link
Member

primeos commented Aug 19, 2020

Any news on this? Would be good to have this soon for testing chromiumBeta (though I could also apply this PR locally).

Is enablePolly = true the only problem that's left?

Also cc @lovek323 @7c6f434c @dtzWill (LLVM maintainers)

@ggreif
Copy link
Contributor Author

ggreif commented Aug 19, 2020 •
edited

Unfortunately the macOS build fails with #94204 (comment) and I have no time right now to fix it. Probably easy to build a monorepo-like layout from the downloaded tarballs, and I assume that not even all are needed. But I have no time right now to do the grunt work, so we can either merge this and accept that Darwin is broken, or start working on it. Polly is well out of my reach, sorry.

@primeos
Copy link
Member

primeos commented Aug 19, 2020

Thanks for the update. Given that this is a new package I would be fine with getting the Darwin support in place later if we have to.

@NixOS/darwin-maintainers do you maybe have time to take a look at the Darwin build?

@ggreif ggreif changed the title llvmPackages_11: start with 11.0.0rc1 llvmPackages_11: start with 11.0.0rc2 Aug 21, 2020
@ggreif
Copy link
Contributor Author

ggreif commented Aug 21, 2020

@GrahamcOfBorg build clang_11

primeos added a commit that referenced this pull request Aug 25, 2020
@primeos
Merge branch 'llvm_11' into master
28aef45 
This merges #94204 with the only difference being that I modified the
history into three commits that should be easier to review and
understand.

Original history: 3524f4c
Modified history: df267a4
@primeos
Copy link
Member

primeos commented Aug 25, 2020

Ok, so I just refactored/squashed the history and merged this in 28aef45 :)

Thanks for your work @ggreif and @conferno ❤️

@primeos primeos closed this Aug 25, 2020
@primeos primeos mentioned this pull request Nov 27, 2022
Merged
13 tasks
@rrbutani rrbutani mentioned this pull request Jan 8, 2023
Merged
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@dtzWill dtzWill Awaiting requested review from dtzWill

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggreif @primeos