Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhall-lsp-server: init at 1.0.8 on all packages #94215

Merged
merged 1 commit into from Jul 31, 2020
Merged

dhall-lsp-server: init at 1.0.8 on all packages #94215

merged 1 commit into from Jul 31, 2020

Conversation

mikefaille
Copy link
Contributor

Motivation for this change

For now, I use configuration.nix to configure my dev. env. and then it's nice for me to get dhall-lsp-server available from all-packages.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mikefaille mikefaille changed the title dhall: init at 1.0.8 on all packages dhall-lsp-server: init at 1.0.8 on all packages Jul 30, 2020
jonringer
jonringer approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

cc @cdepillabout

@cdepillabout
Copy link
Member

@GrahamcOfBorg build dhall-lsp-server

@cdepillabout
Copy link
Member

Looks good to me, thanks for adding this.

@cdepillabout cdepillabout merged commit 471f367 into NixOS:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikefaille @cdepillabout @jonringer