Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hnix: fix build for ghc-8.10 by adding repline #94217

Merged
merged 1 commit into from Jul 30, 2020
Merged

haskellPackages.hnix: fix build for ghc-8.10 by adding repline #94217

merged 1 commit into from Jul 30, 2020

Conversation

sorki
Copy link
Member

@sorki sorki commented Jul 30, 2020

Motivation for this change

Fix breakage with GHC 8.10. Since executable is disabled by default cabal2nix won't pick up repline dep for it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sorki sorki requested a review from cdepillabout as a code owner July 30, 2020 06:50
@cdepillabout
Copy link
Member

Looks good, thanks!

@cdepillabout cdepillabout merged commit 764198a into NixOS:haskell-updates Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sorki @cdepillabout