Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightburn: init at 0.9.15 #94232

Merged
merged 1 commit into from Aug 21, 2020
Merged

lightburn: init at 0.9.15 #94232

merged 1 commit into from Aug 21, 2020

Conversation

q3k
Copy link
Member

@q3k q3k commented Jul 30, 2020

Motivation for this change

This implements a derivation for LightBurn, a laser control software. It's binary and non-free, so we wrap it appropriately.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented Jul 31, 2020

Do not have hardware on hand right now but it starts correctly and opens my previous files correctly. (I've used a similar derivation in a local overlay for a while).

I haven't upstreamed it because I wasn't sure that less popular closed software like this one had their place on nixpkgs, but I guess I was wrong :).

@Lassulus Lassulus merged commit d5bfee4 into NixOS:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants