Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowdown: init at 0.7.2 #94225

Merged
merged 1 commit into from Aug 4, 2020
Merged

lowdown: init at 0.7.2 #94225

merged 1 commit into from Aug 4, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Add lowdown, a markdown converter plus library.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build lowdown


postInstall = ''
mkdir -p ''${!outputDevman}/share/man
mv ''${!outputMan}/share/man/man3 ''${!outputDevman}/share/man/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn’t bother about devman, it’s just more overhead for little gain (plus it’s confusing when the manpage is missing).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs manual says "$outputMan is for man pages (except for section 3)."

Maybe it's clearer, if we install user man pages to out directly, man3 to devMan and drop the man output altogether?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used outputs = [ "out" "dev" ], any other outputs are overkill given their sizes. For example, lib only contains a static library so it's not useful to have it separate from dev.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane, but this way all manpages end up in out, since a fixup hook moves them there. Might be confusing if the dev docs are shipped with the executables?

@edolstra edolstra merged commit 69f615c into NixOS:master Aug 4, 2020
@sternenseemann sternenseemann deleted the lowdown branch August 4, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants