Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esphome: 1.14.4 -> 1.14.5 #91804

Merged
merged 3 commits into from Jul 8, 2020
Merged

esphome: 1.14.4 -> 1.14.5 #91804

merged 3 commits into from Jul 8, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

esphome: Fix ESP32 interrupt enable/disable switched (cherry-picked)

https://github.com/esphome/esphome/releases/tag/v1.14.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

@mweinelt Please test it with the commit I added.

@mweinelt
Copy link
Member Author

mweinelt commented Jul 2, 2020

Upgraded some of my esphome devices to 1.14.5. LGTM.

[16:11:50][D][api.connection:583]: Client 'Home Assistant 0.112.0 (172.23.42.122)' connected successfully!
[16:12:28][D][bme280.sensor:197]: Got temperature=26.0°C pressure=996.8hPa humidity=36.7%
[16:12:28][D][sensor:092]: '0ea3ab BME280 Temperature': Sending state 25.99000 °C with 1 decimals of accuracy
[16:12:28][D][sensor:092]: '0ea3ab BME280 Pressure': Sending state 996.77704 hPa with 1 decimals of accuracy
[16:12:28][D][sensor:092]: '0ea3ab BME280 Humidity': Sending state 36.69434 % with 1 decimals of accuracy

@mweinelt
Copy link
Member Author

mweinelt commented Jul 2, 2020 •
edited

Oh, it seems to be missing click just now?! They don't mention that in requirements.txt nor setup.py.

Traceback (most recent call last):
  File "/nix/store/0y569sgcc10lhmd9b7fnzg0pxpbzdwfv-esphome-1.14.5/bin/.esphome-wrapped", line 9, in <module>
    sys.exit(main())
  File "/nix/store/0y569sgcc10lhmd9b7fnzg0pxpbzdwfv-esphome-1.14.5/lib/python3.8/site-packages/esphome/__main__.py", line 566, in main
    return run_esphome(sys.argv)
  File "/nix/store/0y569sgcc10lhmd9b7fnzg0pxpbzdwfv-esphome-1.14.5/lib/python3.8/site-packages/esphome/__main__.py", line 535, in run_esphome
    return PRE_CONFIG_ACTIONS[args.command](args)
  File "/nix/store/0y569sgcc10lhmd9b7fnzg0pxpbzdwfv-esphome-1.14.5/lib/python3.8/site-packages/esphome/__main__.py", line 369, in command_update_all
    import click
ModuleNotFoundError: No module named 'click'

Seems they use argparse usually, but fall back to click for update-all.

https://github.com/esphome/esphome/blob/dev/esphome/__main__.py#L364

@mweinelt
Copy link
Member Author

mweinelt commented Jul 2, 2020

Upstream-Issue opened at esphome/issues#1324.

@mweinelt
Copy link
Member Author

mweinelt commented Jul 8, 2020

Upstream added click to their requirements and I think we're good to go here.

@mweinelt mweinelt merged commit bddf762 into NixOS:master Jul 8, 2020
@mweinelt mweinelt deleted the esphome branch July 8, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @dotlambda