Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio{,-headless}-experimental: 0.18.32 -> 0.18.34, add priegger to maintainers #91763

Merged
merged 3 commits into from Jun 29, 2020
Merged

factorio{,-headless}-experimental: 0.18.32 -> 0.18.34, add priegger to maintainers #91763

merged 3 commits into from Jun 29, 2020

Conversation

priegger
Copy link
Contributor

@priegger priegger commented Jun 29, 2020 •
edited

Motivation for this change
  • Update factorio experimental package to the latest version.
  • Add myself (priegger) to the maintainers.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from elitak, erictapen and Baughn June 29, 2020 14:09
erictapen
erictapen approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me.

@veprbl veprbl merged commit 9e7d03c into NixOS:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen erictapen approved these changes

@elitak elitak Awaiting requested review from elitak

@Baughn Baughn Awaiting requested review from Baughn

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@priegger @erictapen @veprbl