Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

antimicro 2.3 -> antimicroX 3.0 #91776

Merged
merged 1 commit into from Aug 6, 2020
Merged

antimicro 2.3 -> antimicroX 3.0 #91776

merged 1 commit into from Aug 6, 2020

Conversation

KoviRobi
Copy link
Contributor

Antimicro is broken an no longer maintained (and doesn't compile).
AntimicroX is a fork that does compile, so this removes antimicro and
adds antimicroX.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KoviRobi KoviRobi requested a review from jb55 June 29, 2020 16:22
@KoviRobi
Copy link
Contributor Author

Sorry, I was meant to add a reviewer, not an assignee, and now can't remove you as an assignee.

@KoviRobi
Copy link
Contributor Author

I have been using this software, because of working from home but having to use a work laptop, but my music is on my desktop computer. So I have hooked up a spare PS3 controller, and used this to map buttons to volume up/down, and play/pause. Seems to work fine.

jb55
jb55 approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/248

danieldk
danieldk suggested changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for replacing a broken derivation! Some suggested improvements.

pkgs/tools/misc/antimicroX/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
danieldk
danieldk reviewed Aug 6, 2020
View reviewed changes
pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
antimicro 2.3 -> antimicroX 3.0
1e6f11a 
Antimicro is broken an no longer maintained (and doesn't compile).
AntimicroX is a fork that does compile, so this removes antimicro and
adds antimicroX.
@ofborg ofborg bot requested a review from jb55 August 6, 2020 15:35
danieldk
danieldk approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 91776 1

1 package built:
  • antimicroX

Approved by package maintainer @jb55.

@danieldk danieldk merged commit 39806bc into NixOS:master Aug 6, 2020
@KoviRobi KoviRobi deleted the antimicro-to-antimicroX branch October 10, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@jb55 jb55 Awaiting requested review from jb55

Assignees

@jb55 jb55

Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KoviRobi @nixos-discourse @jb55 @danieldk