Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pango: 1.44.7 -> 1.45.3 #91777

Merged
merged 1 commit into from Jul 26, 2020
Merged

pango: 1.44.7 -> 1.45.3 #91777

merged 1 commit into from Jul 26, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jun 29, 2020

Motivation for this change

This update is needed to cleanly apply a patch, which fixes the issue that required to split the outputs of type1 bitmap fonts.
See #75160 for why this is needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (for harfbuzz, mostly negligible)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

For now I've built a VM with xfce and tested a couple GTK applications.

@rnhmjoj rnhmjoj requested a review from jtojnar June 29, 2020 16:37
@ofborg ofborg bot requested review from 7c6f434c and edolstra June 29, 2020 16:45
jtojnar
jtojnar reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is possibly unstable version but if the changes are conservative we can probably merge it.

Away from computer today and tomorrow so cannot review the changes at the moment.

pkgs/development/libraries/harfbuzz/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/pango/default.nix Outdated Show resolved Hide resolved
@FRidh FRidh added this to WIP in Staging via automation Jul 2, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Jul 2, 2020
@rnhmjoj rnhmjoj changed the base branch from master to staging-18.03 July 16, 2020 14:18
@rnhmjoj rnhmjoj changed the base branch from staging-18.03 to staging July 16, 2020 14:20
@jtojnar
Copy link
Contributor

jtojnar commented Jul 20, 2020

I think it is fine. The changelogs did not mention any API changes, if I did not miss something, so hopefully nothing should break.

@jtojnar
Copy link
Contributor

jtojnar commented Jul 20, 2020

Would be nice if the darwin build succeeded, though.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 22, 2020

@GrahamcOfBorg build pango harfbuzz

@jtojnar jtojnar mentioned this pull request Jul 25, 2020
Merged
10 tasks
@cdepillabout
Copy link
Member

cdepillabout commented Jul 25, 2020 •
edited

@rnhmjoj Would you be able to pull in the "--enable-introspection=yes" line from #93799?

Or, it looks like the darwin build has succeeded, so maybe this could just be merged in? And then I'll rebase #93799 on top of this PR.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 26, 2020

Finally the darwin test passed. Let's merge it.

@rnhmjoj rnhmjoj merged commit 500f48b into NixOS:staging Jul 26, 2020
Staging automation moved this from Ready to Done Jul 26, 2020
@rnhmjoj rnhmjoj mentioned this pull request Aug 30, 2020
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@edolstra edolstra Awaiting requested review from edolstra

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @7c6f434c @jtojnar @cdepillabout