Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.{confuse,mediafile}: init #91789

Merged
merged 2 commits into from Jan 2, 2021

Conversation

lovesegfault
Copy link
Member

Motivation for this change

These will soon be needed for a new release of beets

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/development/python-modules/confuse/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mediafile/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mediafile/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mediafile/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mediafile/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/confuse/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/confuse/default.nix Outdated Show resolved Hide resolved
@lovesegfault
Copy link
Member Author

@jonringer Fastest review in the west! I think I got everything :)

@lovesegfault
Copy link
Member Author

Result of nixpkgs-review pr 91789 run on x86_64-linux 1

6 packages built:
  • python37Packages.confuse
  • python37Packages.mediafile
  • python38Packages.confuse
  • python38Packages.mediafile
  • python39Packages.confuse
  • python39Packages.mediafile

@lovesegfault lovesegfault merged commit 0b0760b into NixOS:master Jan 2, 2021
@lovesegfault lovesegfault deleted the confuse-mediafile branch January 2, 2021 02:43
@fabaff fabaff mentioned this pull request Feb 13, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants