Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] nomad: 0.10.2 -> 0.10.5 #91769

Merged
merged 1 commit into from Jun 29, 2020
Merged

[20.03] nomad: 0.10.2 -> 0.10.5 #91769

merged 1 commit into from Jun 29, 2020

Conversation

amaxine
Copy link
Member

@amaxine amaxine commented Jun 29, 2020

Motivation for this change

Bump to latest version in series. Fixes #90932?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@amaxine amaxine changed the title nomad: 0.10.2 -> 0.10.5 [20.03] nomad: 0.10.2 -> 0.10.5 Jun 29, 2020
@ofborg ofborg bot requested review from ehmry, rushmorem and endocrimes June 29, 2020 15:36
@srhb
Copy link
Contributor

srhb commented Jun 29, 2020

Hi and thank you!

Changes to the stable branch (here, 20.03) should go to the corresponding release branch (release-20.03) from which Hydra will build them and eventually (when tests succeed) the channel scripts will promote the nixos-20.03 branch to that succesful commit. Please rebase on release-20.03. 😃

@amaxine amaxine changed the base branch from nixos-20.03 to release-20.03 June 29, 2020 21:07
@amaxine
Copy link
Member Author

amaxine commented Jun 29, 2020

Sure thing! Sorry, didn't know the process and didn't really find it with a quick search 😅

This should be fine then?

@srhb
Copy link
Contributor

srhb commented Jun 29, 2020

Yep, perfect. Thanks!

@srhb srhb merged commit 244286e into NixOS:release-20.03 Jun 29, 2020
@endocrimes endocrimes mentioned this pull request Jun 30, 2020
Closed
3 tasks
@amaxine amaxine deleted the nomad_20.03_0.10.5 branch June 30, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

@rushmorem rushmorem Awaiting requested review from rushmorem

@endocrimes endocrimes Awaiting requested review from endocrimes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amaxine @srhb