Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amdvlk: 2020.Q2.5 -> 2020.Q2.6 #91845

Merged
merged 1 commit into from Jun 30, 2020
Merged

amdvlk: 2020.Q2.5 -> 2020.Q2.6 #91845

merged 1 commit into from Jun 30, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Jun 30, 2020

Motivation for this change

Version 2020.Q2.6 was published: https://github.com/GPUOpen-Drivers/AMDVLK/releases/tag/v-2020.Q2.6

Things done

Tested nixpkgs-review, vkcube and Dota 2.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 91845 1

1 package built:
- amdvlk

Output contains expected files.

@danieldk danieldk merged commit 5d4d7c2 into NixOS:master Jun 30, 2020
@Flakebi Flakebi deleted the amdvlk branch June 30, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flakebi @danieldk