Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcs3: fix vulkan renderer #91762

Merged
merged 1 commit into from Jun 29, 2020
Merged

rpcs3: fix vulkan renderer #91762

merged 1 commit into from Jun 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 29, 2020

Motivation for this change

This pr adds vulkan-headers to the rpcs3 package, they are needed for building its Vulkan rendering backend.
Without them Vulkan can't be used for rendering.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

RPCS3 needs vulkan-headers for building its Vulkan rendering backend.
@Mic92 Mic92 merged commit f3ee2cd into NixOS:master Jun 29, 2020
@ghost ghost deleted the fix/rpcs3-vulkan branch June 30, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant