Fix #7945: Add cost of clearing the sloped tile when placing a dock #7947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuXarick
force-pushed
the
dock-add-cost-of-clearing-sloped-tile
branch
from
99e8fe5
to
fc2bacf
Compare
|
I think this should be 2 commits - the first 2 - (Add cost of... + regression fix) & and the next 2 (Using "Change: Allow..." commit message). Can you squash together accordingly? |
SamuXarick
force-pushed
the
dock-add-cost-of-clearing-sloped-tile
branch
from
8f37ea1
to
3085ca8
Compare
LordAro
previously approved these changes
Jan 19, 2020
SamuXarick
force-pushed
the
dock-add-cost-of-clearing-sloped-tile
branch
from
3085ca8
to
56dd2d5
Compare
Yexo
previously approved these changes
May 10, 2020
glx22
previously requested changes
May 10, 2020
|
Needs conflict resolved in regression test |
SamuXarick
force-pushed
the
dock-add-cost-of-clearing-sloped-tile
branch
from
56dd2d5
to
d1acb81
Compare
TrueBrain
added
candidate: most likely
SamuXarick
force-pushed
the
dock-add-cost-of-clearing-sloped-tile
branch
from
d1acb81
to
42c9a11
Compare
TrueBrain
force-pushed
the
dock-add-cost-of-clearing-sloped-tile
branch
from
42c9a11
to
8ad11bd
Compare
|
I removed the second commit from this PR; I have no clue what it is doing, why it is there, or why we would want it. It contains no documentation of the change, no reference to what it fixes, etc etc etc. Seems some people never learn ;) The other commit is valid, and resolves a bug. |
TrueBrain
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7945